-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use envtest binaries from controller-tools repo #4888
Use envtest binaries from controller-tools repo #4888
Conversation
Thx! /lgtm |
LGTM label has been added. Git tree hash: 206227094aa81c178af13506fa480882ccd48353
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates
setup-envtest
to a commit onmain
that fetchesenvtest
binaries from the GitHub release on the controller-tools repo. This is to move away from using GCP resource buckets.Which issue(s) this PR fixes:
None, but see
Special notes for your reviewer:
TODOs:
Release note:
Thanks @sbueringer for always being on top of things like this!